Put magic number into constant.

diff --git a/classes/add_warning_form.php b/classes/add_warning_form.php
index c21ad5e..0b9c238 100644 (file)
--- a/classes/add_warning_form.php
+++ b/classes/add_warning_form.php
@@ -52,7 +52,7 @@ class mod_attendance_add_warning_form extends moodleform {
         $mform->setDefault('warningpercent', $config->warningpercent);
 
         $options = array();
-        for ($i = 1; $i <= 50; $i++) {
+        for ($i = 1; $i <= ATTENDANCE_MAXWARNAFTER; $i++) {
             $options[$i] = "$i";
         }
         $mform->addElement('select', 'warnafter', get_string('warnafter', 'mod_attendance'), $options);

diff --git a/locallib.php b/locallib.php
index b364d86..efa2405 100644 (file)
--- a/locallib.php
+++ b/locallib.php
@@ -43,6 +43,9 @@ define('ATTENDANCE_AUTOMARK_DISABLED', 0);
 define('ATTENDANCE_AUTOMARK_ALL', 1);
 define('ATTENDANCE_AUTOMARK_CLOSE', 2);
 
+// Max number of sessions available in the warnings set form to trigger warnings.
+define('ATTENDANCE_MAXWARNAFTER', 100);
+
 /**
  * Get statuses,
  *